Re: Supporting "-v" option for git-log

From: Jeff King <peff@peff.net>
Date: May 25, 2011, 15:11 UTC
Message-ID: <20110525151115.GB8795@sigill.intra.peff.net>
In-Reply-To: <m3boyqzy3f.fsf@localhost.localdomain>

On Wed, May 25, 2011 at 06:53:31AM -0700, Jakub Narebski wrote:

Show 9 quoted lines

> > Which is a shame, because we already have all of the code for "--and",
> > "--or", and "--not" in git-grep. It is just a syntactic conflict. I
> > think you could get away with "--grep-and", "--grep-or", and
> > "--grep-not". They are obviously less nice to type, but there would be
> > not conflict.
> 
> Hmmm... perhaps short -! could be alias for --grep-not (it is the only
> that needs to be changed to avoid conflict, as there are no --or and
> --and for rev-list).

Ick. I really hate using shell metacharacters that need quoting (especially "!", which even gets expanded inside double-quotes). But as long as it's an alias, I guess people who care can use --grep-not.

We could use unadorned "--or" and "--and", though we should perhaps stop and think whether taking those basic operators will block future use that matches the current "--not" more.

Right now, "git log a b" is what I would expect "git log a --or b" to do. I guess "git log a --and b" would be "git log $(git merge-base a b)". So maybe it is not worth reserving them for the future, since what they would (probably) accomplish is easy to do now.

-Peff