Re: [PATCH] Port to 12 other Platforms.

From: Boyd Lynn Gerber <gerberb@zenez.com>
Date: Jun 8, 2008, 16:33 UTC
Message-ID: <Pine.LNX.4.64.0806081028460.18454@xenau.zenez.com>
In-Reply-To: <vpqve0j3nkd.fsf@bauges.imag.fr>

On Sun, 8 Jun 2008, Matthieu Moy wrote:

Show 7 quoted lines

> Boyd Lynn Gerber <gerberb@zenez.com> writes:
> > This was from my own copy of the master archive.  It is my proposal.  I 
> > thought you had to get an OK from this list before you do a push to the 
> > main archive.
> 
> You won't do a push, the maintainer will apply the patch if it seems
> OK.

Thanks, I understand better now.

Show 7 quoted lines

> > What am I missing?
> 
> The format used to send patches. git format-patch and git send-email
> would do that for you, but in particular : what comes after « --- »
> and before the patch itself is ignored by the tools, just an
> informative message for people reading your email. What comes before
> this « --- » is the commit message.

I moved the message from above my commiter message because I was told to add comments after the --- with the file being modified. The reasons for the modifications. I used git format-patch -p -M -B origin to generate this email. All I did was read the contents into the email I create for posting. This was the advice I was given on IRC as the best method to create/send the patch. When on IRC I was omitting the -p and was not getting the .patch file. After reading the docs over and over I finally noticed I was missing the -p. Once I added it I got the patch file and then I emailed it to the list.

Thanks,

-- Boyd Gerber <gerberb@zenez.com> ZENEZ 1042 East Fort Union #135, Midvale Utah 84047