Re: [PATCH] Port to 12 other Platforms.

From: Jakub Narebski <jnareb@gmail.com>
Date: Jun 8, 2008, 17:19 UTC
Message-ID: <200806081919.05273.jnareb@gmail.com>
In-Reply-To: <Pine.LNX.4.64.0806081028460.18454@xenau.zenez.com>

On Sun, 8 Jun 2008, Boyd Lynn Gerber wrote:

Show 11 quoted lines

> On Sun, 8 Jun 2008, Matthieu Moy wrote:
>> Boyd Lynn Gerber <gerberb@zenez.com> writes:
>>>
>>> This was from my own copy of the master archive.  It is my proposal.  I 
>>> thought you had to get an OK from this list before you do a push to the 
>>> main archive.
>> 
>> You won't do a push, the maintainer will apply the patch if it seems
>> OK.
> 
> Thanks, I understand better now.

By the way, if you want to send large series of patches, and you have your git repository published somewhere (repo.or.cz, gitorious, github, freedektop, kernel.org), sometimes pull request is used. As you usually use git-format-patch (perhaps together with git-send-email) when sending patches, you can use output of git-request-pull there.

Just FYI, you can safely ignore above.

Show 17 quoted lines

>>> What am I missing?
>> 
>> The format used to send patches. git format-patch and git send-email
>> would do that for you, but in particular : what comes after « --- »
>> and before the patch itself is ignored by the tools, just an
>> informative message for people reading your email. What comes before
>> this « --- » is the commit message.
> 
> I moved the message from above my commiter message because I was told to 
> add comments after the --- with the file being modified.  The reasons for 
> the modifications.  I used git format-patch -p -M -B origin to generate 
> this email.  All I did was read the contents into the email I create for 
> posting.  This was the advice I was given on IRC as the best method to 
> create/send the patch.  When on IRC I was omitting the -p and was not 
> getting the .patch file.  After reading the docs over and over I finally 
> noticed I was missing the -p.  Once I added it I got the patch file and 
> then I emailed it to the list.

Strange. While in git-diff family of commands '-p' means generate diff in patchset format:

       -p     Generate patch (see section on generating patches).

it has different meaning (oops) in git-format-patch:

       -p     Generate patches without diffstat.

(What is probably a bug in git-format-patch it doesn't add "---\n" separator between commit message and patch itself).

Everything between "---\n" after commit message (usually ending in Signed-off-by) and the diffstat and patch is a transient comment, which won't get included in commit message, and wouldn't be anywhere in the repository, neither in contents not in commits.

What you put there is information which shouldn't be in commit message, like for example difference from previous version of patch, sometimes explanation behind _why_ of this patch; you put there to which branch this patch applies, if it is not 'master' (por example if it requires material from 'next') or if given patch depends on earlier patch NOT in the series.

IMVVVHO you should put verbatim copy of certificate of origin there, but put the comment about which operating systems needs which defines, or use which defines, and why either in commit message, in comment in some file, or both.

HTH (Hope That Helps).

-- 
Jakub Narebski
Poland