Re: [PATCH] transport.c: call dash-less form of receive-pack and upload-pack on remote

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 1, 2007, 10:17 UTC
Message-ID: <Pine.LNX.4.64.0712010959180.27959@racer.site>
In-Reply-To: <7vlk8f9m52.fsf@gitster.siamese.dyndns.org>

Hi,

On Fri, 30 Nov 2007, Junio C Hamano wrote:

Show 20 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > Since we plan to move the dash-form (git-<whatever>) into an execdir, it
> > make sense to prepare our git protocol users for it.
> >
> > Noticed by Eyvind Bernhardsen.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> >
> > 	On Fri, 30 Nov 2007, Eyvind Bernhardsen wrote:
> >
> > 	> - When pushing to my system over ssh, git-receive-pack and
> > 	> git-upload-pack are expected to be in $PATH.  I resolved the 
> > 	> problem by putting symlinks in /usr/local/bin.
> >
> > 	How about this?  (I only compile-tested it...)
> 
> I only eyeball-tested it and looks Okay, but that does not assure us
> much ;-).  Is this change easy to test using local transport?

Seems like it breaks down with git-shell. But then, I think that we just have to fix execv_git_cmd() to call builtins via "git" instead.

Ciao, Dscho