Re: [PATCH] Move all dashed form git commands to libexecdir
- From
Jeff King <peff@peff.net>
- Date
- Nov 30, 2007, 18:37 UTC
- Message-ID
- <20071130183755.GA29382@sigill.intra.peff.net>
- In-Reply-To
- <Pine.LNX.4.64.0711301828050.27959@racer.site>
On Fri, Nov 30, 2007 at 06:28:50PM +0000, Johannes Schindelin wrote:
Show 12 quoted lines
> > @@ -162,6 +169,8 @@ static int handle_alias(int *argcp, const char ***argv)
> >
> > alias_command = (*argv)[0];
> > git_config(git_alias_config);
> > + if (!alias_string)
> > + alias_string = builtin_alias(alias_command);
> > if (alias_string) {
> > if (alias_string[0] == '!') {
> > if (*argcp > 1) {
>
> Didn't you mean to put this _before_ the git_config() call? As you wrote
> it, the "soft" alias overrides the user-specified one.No. The "if (!alias_string)" means we only do the lookup if no user alias was found. Try it.
-Peff