Re: [PATCH,RFC 1/2] Make the list of common commands more exclusive

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 12, 2007, 12:23 UTC
Message-ID: <Pine.LNX.4.64.0711121222310.4362@racer.site>
In-Reply-To: <20071112102412.GA24803@glandium.org>

Hi,

On Mon, 12 Nov 2007, Mike Hommey wrote:

Show 13 quoted lines

> On Sun, Nov 11, 2007 at 11:26:10PM -0800, Junio C Hamano <gitster@pobox.com> wrote:
> > > My mental model for git newbies is that they would probably be pulling
> > > from upstream repositories (so I was tempted to remove git-init from
> > > the common commands list), but they would rarely be cherry-picking or
> > > reverting other people's changes.
> > 
> > I'd agree with that, but reverting and cherry-picking would also
> > be done on the commits the user builds on top of other people's
> > changes.
> 
> On the other hand, cherry-picking and reverting are just the same thing, 
> except one applies a reversed patch. Wouldn't it make sense to merge 
> these two in one command ?

Technically, they are. That's why both of them live in builtin-revert.c. But conceptually, they are not. At least _I_ found it hard at first, to accept that reverting a patch really was a reverse cherry-picking.

Ciao, Dscho