git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Obscure commit message formatting issue

From
Daniel Barkalow <barkalow@iabervon.org>
Date
Nov 11, 2007, 22:50 UTC
Message-ID
<Pine.LNX.4.64.0711111744090.29952@iabervon.org>
In-Reply-To
<Pine.LNX.4.64.0711112240350.4362@racer.site>
On Sun, 11 Nov 2007, Johannes Schindelin wrote:
Show 36 quoted lines
> Hi,
> 
> On Sun, 11 Nov 2007, Daniel Barkalow wrote:
> 
> > On Sun, 11 Nov 2007, Junio C Hamano wrote:
> > 
> > > Daniel Barkalow <barkalow@iabervon.org> writes:
> > > 
> > > > The current code drops extra blank lines between the first line of a 
> > > > commit message (the summary line) and the remainder.
> > > 
> > > The patch application side does even more.  It not just strips
> > > off the leading or trailing blank lines, but duplicate blank
> > > lines in the middle and trailing whitespaces at the end of each
> > > line.
> > > 
> > > I am of two minds about the formatting side.
> > > 
> > > The behaviour you found does not go far enough to correct all of
> > > the above whitespace breakage the application side will fix up
> > > on the generation side -- it only corrects one of them.  We
> > > might want to do more, instead of less that you seem to be
> > > implying to favor.
> > 
> > What I'm actually doing is working on a cover letter implementation.
> 
> Funny.
> 
> I am in the middle of cleaning out my personal git branch that has a messy 
> history, since I never rebased, but always merged.  Now I decided to go 
> with rebasing.
> 
> And there I found an implementation of a cover letter.  You might want to 
> be interested ;-)
> 
> 	http://repo.or.cz/w/git/dscho.git?a=shortlog;h=cover-letter

I actually started from the patch you sent me a while back, but using code from pretty.c instead of generating the message directly. I'll have to check whether you added anything since the patch I got.

	-Daniel
*This .sig left intentionally blank*
Previous: Johannes Schindelin
Message 5 of 5 in “Obscure commit message formatting issue”
  1. Daniel BarkalowNov 11, 2007
  2. Junio C HamanoNov 11, 2007
  3. Daniel BarkalowNov 11, 2007
  4. Johannes SchindelinNov 11, 2007
  5. Daniel BarkalowNov 11, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.