Re: Obscure commit message formatting issue

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Nov 11, 2007, 22:30 UTC
Message-ID: <Pine.LNX.4.64.0711111706490.29952@iabervon.org>
In-Reply-To: <7vprygbfwf.fsf@gitster.siamese.dyndns.org>

On Sun, 11 Nov 2007, Junio C Hamano wrote:

Show 17 quoted lines

> Daniel Barkalow <barkalow@iabervon.org> writes:
> 
> > The current code drops extra blank lines between the first line of a 
> > commit message (the summary line) and the remainder.
> 
> The patch application side does even more.  It not just strips
> off the leading or trailing blank lines, but duplicate blank
> lines in the middle and trailing whitespaces at the end of each
> line.
> 
> I am of two minds about the formatting side.
> 
> The behaviour you found does not go far enough to correct all of
> the above whitespace breakage the application side will fix up
> on the generation side -- it only corrects one of them.  We
> might want to do more, instead of less that you seem to be
> implying to favor.

What I'm actually doing is working on a cover letter implementation. I'd like to use the same code that generates the subject line and message for patches to generate the cover letter text from some source material, if there is source material, but have "insert text here" markers if there is no pre-existing text. But the "insert text here" marker for a paragraph looks odd if it's a single line of vertical space, and it's annoying if the space is full of text that has to be removed, and it's again odd if the text isn't centered. So I want it to start with a blank line. But the current code can't generate a text like that.

Reversability isn't all that important to me in this case, although it seems to me to be generally desirable for rebase. For email that actually goes through people, I'd expect it to get further manipulated by humans, so it doesn't matter so much there, aside from being able to arrange the input so that you can get the intermediate form you want.

	-Daniel
*This .sig left intentionally blank*