Re: [PATCH] Make builtin-tag.c use parse_options.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 9, 2007, 14:31 UTC
Message-ID: <Pine.LNX.4.64.0711091429120.4362@racer.site>
In-Reply-To: <fh1p10$nta$1@ger.gmane.org>

Hi,

[re Cc:ing jasam]

On Fri, 9 Nov 2007, Jakub Narebski wrote:

Show 9 quoted lines

> Carlos Rica wrote:
> 
> > +     struct option options[] = {
> > +             { OPTION_STRING, 'l', NULL, &list, "pattern", "list tag names",
> > +                     PARSE_OPT_OPTARG, NULL, (intptr_t) no_pattern },
> 
> > +             OPT_STRING('F', NULL, &msgfile, "file", "message in a file"),
> 
> Does it matter that you use OPTION_STRING here and OPT_STRING macro there?

I guess it is because of the PARSE_OPT_OPTARG thing, together with no_pattern. We need to know if -l was specified, even if no argument was passed in.

Hth, Dscho