Re: [PATCH] git-branch --with=commit

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 8, 2007, 03:02 UTC
Message-ID: <Pine.LNX.4.64.0711080300100.4362@racer.site>
In-Reply-To: <7vk5ot7aqz.fsf@gitster.siamese.dyndns.org>

Hi,

On Wed, 7 Nov 2007, Junio C Hamano wrote:

Show 7 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > would it not be better to call it --containing=commit?  Besides, I 
> > think that the opt_parse_with_commit() function would be better named 
> > opt_parse_commit() and be put into parse-options.[ch].
> 
> git-describe has "--contains" so that may be a better match.

I just thought what I would understand when reading "git branch --with=master". I would have expected that it branches off of master.

> I do not know the particular function is generic enough to be in 
> parse-options.

Maybe not, you're right. And we can always come back later, and expose the function if need be.

Ciao, Dscho