Re: [PATCH] Make git-clean a builtin

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 7, 2007, 15:04 UTC
Message-ID: <Pine.LNX.4.64.0711071501270.4362@racer.site>
In-Reply-To: <20071107145434.GB6768@mediacenter.austin.rr.com>

Hi,

On Wed, 7 Nov 2007, Shawn Bohrer wrote:

Show 19 quoted lines

> On Wed, Nov 07, 2007 at 11:10:45AM +0000, Johannes Schindelin wrote:
> > 
> > you still have quite a number of instances where you wrap just one line 
> > into curly brackets:
> > 
> > 	if (bla) {
> > 		[just one line]
> > 	}
> 
> Crap.  OK I count one instance unless you count:
> 
> 	if (foo) {
> 		one_line();
> 	} else if (bar) {
> 		one_line();
> 		two_lines();
> 	} else {
> 		something_else();
> 	}

I do count them. Personally, I find it highly distracting and ugly. Besides, we have the convention of putting the "}" not into the same line as "else". (See keyword "uncuddling" in the list archives.)

While it may be true that some parts of the code follow these rules less strictly, it does not mean that we should introduce more of that kind.

BTW there are plenty of examples in the existing code which illustrate our implicit coding conventions.

> Now I suppose I can get rid of the curly braces here as well but I 
> personally find that strange and ugly.  So is there an official 
> guideline on if else statements?

Not yet ;-) I can add it to the tentative v3 of Documentation/CodingStyle or CodingConventions or however the list would like to name it.

Ciao, Dscho