Re: [PATCH] Make git-clean a builtin

From: Shawn Bohrer <shawn.bohrer@gmail.com>
Date: Nov 7, 2007, 14:54 UTC
Message-ID: <20071107145434.GB6768@mediacenter.austin.rr.com>
In-Reply-To: <Pine.LNX.4.64.0711071110040.4362@racer.site>

On Wed, Nov 07, 2007 at 11:10:45AM +0000, Johannes Schindelin wrote:

Show 7 quoted lines

> 
> you still have quite a number of instances where you wrap just one line 
> into curly brackets:
> 
> 	if (bla) {
> 		[just one line]
> 	}

Crap.  OK I count one instance unless you count:

	if (foo) {
		one_line();
	} else if (bar) {
		one_line();
		two_lines();
	} else {
		something_else();
	}

Now I suppose I can get rid of the curly braces here as well but I personally find that strange and ugly. So is there an official guideline on if else statements?

Of course I'll fix the other one I missed and send a new patch.