Re: [PATCH 2/3] parseopt: introduce OPT_RECURSE to specify shared options

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 5, 2007, 13:46 UTC
Message-ID: <Pine.LNX.4.64.0711051340490.4362@racer.site>
In-Reply-To: <Pine.LNX.4.64.0711051315300.4362@racer.site>

Hi,

On Mon, 5 Nov 2007, Johannes Schindelin wrote:

Show 10 quoted lines

> The diff options should not need to be defined in every user of the
> diffcore.  This provides the framework:
> 
> 	extern struct option *diff_options;
> 
> 	struct option options[] = {
> 		OPT_RECURSE(diff_options),
> 		...
> 		OPT_END(),
> 	};

After kicking this around a bit more on IRC, we had another idea. Instead of introducing OPT_RECURSE(), do something like OPT__QUIET(), only this time in diff.h:

#define OPT__DIFF(opt) \
	OPT_BOOLEAN('p', NULL, &opt.format_patch, "show a patch"), \
	...

Pierre said this feels a bit "80s", so I'd like to hear other people's opinions.

Hmm?

Ciao, Dscho