Re: [PATCH 2/3] parseopt: introduce OPT_RECURSE to specify shared options

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 5, 2007, 21:48 UTC
Message-ID: <7vd4uonz30.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <Pine.LNX.4.64.0711051340490.4362@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 12 quoted lines

> After kicking this around a bit more on IRC, we had another idea.  Instead 
> of introducing OPT_RECURSE(), do something like OPT__QUIET(), only this 
> time in diff.h:
>
> #define OPT__DIFF(opt) \
> 	OPT_BOOLEAN('p', NULL, &opt.format_patch, "show a patch"), \
> 	...
>
> Pierre said this feels a bit "80s", so I'd like to hear other people's 
> opinions.
>
> Hmm?

As I am from "80s" ;-) I like the simpler "macro" one much better. There aren't many things that can go wrong in the approach.