Re: Warning: cvsexportcommit considered dangerous

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 4, 2007, 21:35 UTC
Message-ID: <Pine.LNX.4.64.0711042133330.4362@racer.site>
In-Reply-To: <623F4AFA-FE43-4046-9D3F-435396BBE17D@zib.de>

Hi,

On Sun, 4 Nov 2007, Steffen Prohaska wrote:

Show 22 quoted lines

> On Nov 4, 2007, at 5:41 PM, Johannes Schindelin wrote:
> 
> > ever since the up-to-date check was changed to use just one call to 
> > "cvs status", a bug was present.  Now cvsexportcommit expects "cvs 
> > status" to return the results in the same order as the file names were 
> > passed.
> > 
> > This is not true, as I had to realise with one of my projects on 
> > sourceforge.
> > 
> > Since time is so scarce on my side, I will not have time to fix this 
> > bug, but will instead return to my old "commit by hand" procedure.
> 
> I introduced this 'optimization', which turned out to be a bug. So, I 
> feel responsible. Sorry for the trouble.
> 
> In August this was already recognized and a patch submitted:
> 
> http://marc.info/?t=118718458000004&r=1&w=2
> 
> I do not know why it wasn't applied. I forgot re-checking after my 
> vacation.

It slipped by me, because of holiday, too. (I was on my well needed holiday then.)

But that patch really seems like a step back to me.  The line "File: ... 
Status: ..." should be parsable enough to fix the bug properly, instead of 
undoing the optimisation.

AFAICS Robin replied with a "let's see if a proper fix materialises", and I kind of hope that it will materialise soon.

Ciao, Dscho