Re: Warning: cvsexportcommit considered dangerous

From: Steffen Prohaska <prohaska@zib.de>
Date: Nov 4, 2007, 18:16 UTC
Message-ID: <623F4AFA-FE43-4046-9D3F-435396BBE17D@zib.de>
In-Reply-To: <Pine.LNX.4.64.0711041638270.4362@racer.site>

On Nov 4, 2007, at 5:41 PM, Johannes Schindelin wrote:

Show 12 quoted lines

> ever since the up-to-date check was changed to use just one call to  
> "cvs
> status", a bug was present.  Now cvsexportcommit expects "cvs  
> status" to
> return the results in the same order as the file names were passed.
>
> This is not true, as I had to realise with one of my projects on
> sourceforge.
>
> Since time is so scarce on my side, I will not have time to fix  
> this bug,
> but will instead return to my old "commit by hand" procedure.

I introduced this 'optimization', which turned out to be a bug. So, I feel responsible. Sorry for the trouble.

In August this was already recognized and a patch submitted:

http://marc.info/?t=118718458000004&r=1&w=2

I do not know why it wasn't applied. I forgot re-checking after my vacation.

I put all on CC who replied to the patch in August.

	Steffen