Re: [PATCH 1/5] pretty describe: add name info to struct commit
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Nov 4, 2007, 14:22 UTC
- Message-ID
- <Pine.LNX.4.64.0711041420430.4362@racer.site>
- In-Reply-To
- <20071104140700.GB3078@steel.home>
Hi,
On Sun, 4 Nov 2007, Alex Riesen wrote:
Show 16 quoted lines
> Ren? Scharfe, Sun, Nov 04, 2007 12:48:22 +0100:
> > diff --git a/commit.h b/commit.h
> > index b661503..80e94b9 100644
> > --- a/commit.h
> > +++ b/commit.h
> > @@ -18,6 +18,9 @@ struct commit {
> > struct commit_list *parents;
> > struct tree *tree;
> > char *buffer;
> > + char *name;
> > + unsigned int name_flags;
> > + char name_prio;
> > };
>
> It increases size of struct commit by ~12 bytes (assuming 4byte
> allignment), and this is a popular structure.I was just about to say something similar.
But there is a wonderful solution: Have a look at decorate.[ch]. This is the structure you should use IMHO.
Ciao, Dscho