Re: [PATCH 1/5] pretty describe: add name info to struct commit

From: Alex Riesen <raa.lkml@gmail.com>
Date: Nov 4, 2007, 14:07 UTC
Message-ID: <20071104140700.GB3078@steel.home>
In-Reply-To: <472DB186.9030909@lsrfire.ath.cx>

René Scharfe, Sun, Nov 04, 2007 12:48:22 +0100:

Show 12 quoted lines

> diff --git a/commit.h b/commit.h
> index b661503..80e94b9 100644
> --- a/commit.h
> +++ b/commit.h
> @@ -18,6 +18,9 @@ struct commit {
>  	struct commit_list *parents;
>  	struct tree *tree;
>  	char *buffer;
> +	char *name;
> +	unsigned int name_flags;
> +	char name_prio;
>  };

It increases size of struct commit by ~12 bytes (assuming 4byte allignment), and this is a popular structure. Besides, the three new fields used by only git-describe, which nobody has in their top-ten used commands (see "best git practices" thread). If the fields are so badly needed (and the information can't (really?) be stored somewhere else), maybe they could be at least compressed when not used:

	struct commit_name_info {
		unsigned int name_flags;
		char name_prio;
		char name[FLEX_ARRAY];
	};

	struct commit {
		struct commit_list *parents;
		struct tree *tree;
		char *buffer;
		struct commit_name_info *name_info;
	};

BTW, do we still have some bits left in struct object->flags? To, for example, switch between normal and expanded structure of second-level object (i.e. commit and commit-with-names).