git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix compilation when NO_CURL is defined

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Oct 16, 2007, 00:05 UTC
Message-ID
<Pine.LNX.4.64.0710160104120.25221@racer.site>
In-Reply-To
<20071015234830.GA9694@spearce.org>
Hi,
On Mon, 15 Oct 2007, Shawn O. Pearce wrote:
> From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Hehe, hardly ;-)
Show 23 quoted lines
> There were a few places which did not cope well without curl.  This
> fixes all of them.  We still need to link against the walker.o part
> of the library as some parts of transport.o still call into there
> even though we don't have HTTP support enabled.
> 
> If compiled with NO_CURL=1 we now get the following useful error
> message:
> 
>   $ git-fetch http://www.example.com/git
>   error: git was compiled without libcurl support.
>   fatal: Don't know how to fetch from http://www.example.com/git
> 
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
> ---
> 
>  I think this is a better version of Dscho's original attempt at
>  making NO_CURL=YesPlease actually work again with the builtin
>  fetch series.
> 
>  Makefile    |    6 +++---
>  transport.c |   23 +++++++----------------
>  2 files changed, 10 insertions(+), 19 deletions(-)
Nice!
I like it.

Ciao, Dscho

Previous: Shawn O. Pearce
Message 2 of 2 in “Fix compilation when NO_CURL is defined”
  1. Fix compilation when NO_CURL is definedShawn O. Pearce, Oct 15, 2007
  2. Johannes SchindelinOct 16, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.