From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 16 Oct 2007 00:05:03 GMT
Subject: Re: [PATCH] Fix compilation when NO_CURL is defined
Message-ID: <Pine.LNX.4.64.0710160104120.25221@racer.site>
In-Reply-To: <20071015234830.GA9694@spearce.org>

Hi,

On Mon, 15 Oct 2007, Shawn O. Pearce wrote:

> From: Johannes Schindelin <Johannes.Schindelin@gmx.de>

Hehe, hardly ;-)

> There were a few places which did not cope well without curl.  This
> fixes all of them.  We still need to link against the walker.o part
> of the library as some parts of transport.o still call into there
> even though we don't have HTTP support enabled.
> 
> If compiled with NO_CURL=1 we now get the following useful error
> message:
> 
>   $ git-fetch http://www.example.com/git
>   error: git was compiled without libcurl support.
>   fatal: Don't know how to fetch from http://www.example.com/git
> 
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
> ---
> 
>  I think this is a better version of Dscho's original attempt at
>  making NO_CURL=YesPlease actually work again with the builtin
>  fetch series.
> 
>  Makefile    |    6 +++---
>  transport.c |   23 +++++++----------------
>  2 files changed, 10 insertions(+), 19 deletions(-)

Nice!

I like it.

Ciao,
Dscho