Re: [PATCH] parse-options: Allow abbreviated options when unambiguous

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 14, 2007, 22:12 UTC
Message-ID: <Pine.LNX.4.64.0710142309010.25221@racer.site>
In-Reply-To: <20071014210130.GA17675@soma>

Hi,

On Sun, 14 Oct 2007, Eric Wong wrote:

Show 32 quoted lines

> Pierre Habouzit <madcoder@debian.org> wrote:
> > On Sun, Oct 14, 2007 at 06:02:33PM +0000, Johannes Schindelin wrote:
> > > Hi,
> > > 
> > > On Sun, 14 Oct 2007, Johannes Schindelin wrote:
> > > 
> > > > When there is an option "--amend", the option parser now recognizes 
> > > > "--am" for that option, provided that there is no other option beginning 
> > > > with "--am".
> > > 
> > > And an amend for ultra-abbreviated options (as you noticed on IRC):
> > > 
> > > diff --git a/parse-options.c b/parse-options.c
> > > index afc6c89..acabb98 100644
> > > --- a/parse-options.c
> > > +++ b/parse-options.c
> > > @@ -137,6 +137,11 @@ is_abbreviated:
> > >  				abbrev_flags = flags;
> > >  				continue;
> > >  			}
> > > +			/* negated and abbreviated very much? */
> > > +			if (!prefixcmp("no-", arg)) {
> > > +				flags |= OPT_UNSET;
> > > +				goto is_abbreviated;
> > > +			}
> > >  			/* negated? */
> > >  			if (strncmp(arg, "no-", 3))
> > >  				continue;
> > 
> >   squashed on top on the previous, and pushed to my ph/parseopt branch.
> 
> Awesome.  Thanks to both of you.

Hehe, you're welcome. Pierre even realised that my patch was not complete (it did not catch overly short abbreviations "--n" and "--no"), and that has been fixed, too.

While I have your attention: last weekend, I spoke to a guy from the ffmpeg project, and he said that the only thing preventing them from switching to git was the lack of svn:external support...

(Of course I know that it is more difficult than that: ffmpeg itself is an svn:external of MPlayer, but maybe we can get both of them to switch ;-)

Do you have any idea when/if you're coming around to add that to git-svn?

Ciao, Dscho