Re: [PATCH 6/7] Bisect: factorise "bisect_{bad,good,dunno}" into "bisect_state".

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 14, 2007, 16:15 UTC
Message-ID: <Pine.LNX.4.64.0710141710230.25221@racer.site>
In-Reply-To: <20071014143003.23ae649f.chriscool@tuxfamily.org>

Hi,

On Sun, 14 Oct 2007, Christian Couder wrote:

Show 20 quoted lines

> -bisect_bad() {
> +bisect_state() {
>  	bisect_autostart
> -	case "$#" in
> -	0)
> -		rev=$(git rev-parse --verify HEAD) ;;
> -	1)
> -		rev=$(git rev-parse --verify "$1^{commit}") ;;
> +	state=$1
> +	case "$#,$state" in
> +	0,*)
> +		die "Please call 'bisect_state' with at least one argument." ;;
> +	1,bad|1,good|1,dunno)
> +		rev=$(git rev-parse --verify HEAD) ||
> +			die "Bad rev input: HEAD"
> +		bisect_write "$state" "$rev" ;;
> +	2,bad)
> +		rev=$(git rev-parse --verify "$2^{commit}") ||
> +			die "Bad rev input: $2"
> +		bisect_write "$state" "$rev" ;;

Really?  As far as I see, "2,bad" is an error in the current bisect.

Show 14 quoted lines

> @@ -404,17 +390,15 @@ bisect_run () {
>  	  exit $res
>        fi
>  
> -      # Use "bisect_good" or "bisect_bad"
> -      # depending on run success or failure.
> +      # Find current state depending on run success or failure.
>        if [ $res -gt 0 ]; then
> -	  next_bisect='bisect_bad'
> +	  state='bad'
>        else
> -	  next_bisect='bisect_good'
> +	  state='good'
>        fi

Maybe it is time to have a special exit status for "dunno"? But this is not something to fix in your patch, just an idea for a future patch.

Ciao, Dscho