Re: [PATCH 6/7] Bisect: factorise "bisect_{bad,good,dunno}" into "bisect_state".

From: Christian Couder <chriscool@tuxfamily.org>
Date: Oct 16, 2007, 06:28 UTC
Message-ID: <200710160828.05137.chriscool@tuxfamily.org>
In-Reply-To: <Pine.LNX.4.64.0710151338000.25221@racer.site>

Hi Dscho,

Le lundi 15 octobre 2007, Johannes Schindelin a écrit :

Show 12 quoted lines

> Hi,
>
> On Mon, 15 Oct 2007, Christian Couder wrote:
> >
> > But the new "bisect_state" takes one more argument, because the first
> > one must be "good" "bad" or "dunno".
> >
> > So when there is only one argument HEAD is used, and when there are 2
> > arguments, $2 is used as the good|bad|dunno rev.
>
> Ah, that explains it!  But do you not need to do "2,bad|2,good|2,dunno"
> in that case?  Or even better: "2,*"?

Perhaps it would be an improvement at least in speed for "2,good" or "2,dunno".

I wanted to keep exactly the same processing as there was before, in case something like "git bisect good v1.5.3.3..v1.5.3.4" was supported. But it seems it doesn't work. I don't know if it's a bug or a feature.

Christian.