Re: [PATCH] git-init: don't base core.filemode on the ability to chmod.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 3, 2007, 23:54 UTC
Message-ID: <Pine.LNX.4.64.0710040053380.28395@racer.site>
In-Reply-To: <20071003231941.GA20800@admingilde.org>

Hi,

On Thu, 4 Oct 2007, Martin Waitz wrote:

Show 5 quoted lines

> -		filemode = (!chmod(path, st1.st_mode ^ S_IXUSR) &&
> +		/* test that new files are not created with X bit */
> +		filemode = !(st1.st_mode & S_IXUSR);
> +		/* test that we can modify the X bit */
> +		filemode &= (!chmod(path, st1.st_mode ^ S_IXUSR) &&

Should that not be &&=?

Ciao, Dscho