Re: [PATCH] git-init: don't base core.filemode on the ability to chmod.

From: Martin Waitz <tali@admingilde.org>
Date: Oct 4, 2007, 07:15 UTC
Message-ID: <20071004071517.GC20800@admingilde.org>
In-Reply-To: <Pine.LNX.4.64.0710040053380.28395@racer.site>

hoi :)

On Thu, Oct 04, 2007 at 12:54:06AM +0100, Johannes Schindelin wrote:

Show 7 quoted lines

> > -		filemode = (!chmod(path, st1.st_mode ^ S_IXUSR) &&
> > +		/* test that new files are not created with X bit */
> > +		filemode = !(st1.st_mode & S_IXUSR);
> > +		/* test that we can modify the X bit */
> > +		filemode &= (!chmod(path, st1.st_mode ^ S_IXUSR) &&
> 
> Should that not be &&=?

originally I wrote it that way but the compiler complaint. I guess we are too used to perl ;-)

-- 
Martin Waitz