Re: [PATCH] new test from the submodule chapter of the user manual

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 20, 2007, 18:47 UTC
Message-ID: <Pine.LNX.4.64.0709201946410.28395@racer.site>
In-Reply-To: <20070920175952.GC30391@tasint.org>

Hi,

On Thu, 20 Sep 2007, Joel Becker wrote:

Show 15 quoted lines

> On Thu, Sep 20, 2007 at 07:08:31PM +0200, Miklos Vajna wrote:
> > +test_expect_success "create the submodules" '
> > +	for i in a b c d
> > +	do
> > +		mkdir $i &&
> > +		cd $i &&
> > +		git init &&
> > +		echo "module $i" > $i.txt &&
> > +		git add $i.txt &&
> > +		git commit -m "Initial commit, submodule $i" &&
> > +		cd ..
> > +	done
> 
> 	Silly question: why use the '&&' when you can 'set -e'?  As it
> currently stands, a failure will still go back around the loop...

A "set -e" will make the script exit AFAIR. That's not what we want. A simple "|| break" after the "cd .." will work, though.

Ciao, Dscho