Re: [PATCH] new test from the submodule chapter of the user manual

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 20, 2007, 21:35 UTC
Message-ID: <7vd4wdkokn.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20070920170831.GQ16235@genesis.frugalware.org>

Miklos Vajna <vmiklos@frugalware.org> writes:

Show 12 quoted lines

> Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
> ---
>
> On Thu, Sep 20, 2007 at 11:34:25AM +0100, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
>> On Wed, 19 Sep 2007, Junio C Hamano wrote:
>> > Looks Ok to me, although I didn't verify the examples by
>> > actually running them myself this time (last round I did).
>>
>> So maybe we should do the same as with the tutorial: stick the examples
>> into a test script?
>
> what about this?

Far too inadequate. You test if "commit" reports success, but do not check if what is committed is what you wanted to commit, for example.