Re: testsuite problems

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 17, 2007, 22:40 UTC
Message-ID: <Pine.LNX.4.64.0709172337470.28586@racer.site>
In-Reply-To: <20070917220408.GG19019@genesis.frugalware.org>

Hi,

On Tue, 18 Sep 2007, Miklos Vajna wrote:

Show 21 quoted lines

> On Mon, Sep 17, 2007 at 11:50:32PM +0200, Ren? Scharfe <rene.scharfe@lsrfire.ath.cx> wrote:
> > The failing tests check ZIP file creation, not tar file creation.
> > Perhaps your unzip command works a bit differently from Info-ZIP's?
> 
> $ zip -v
> Copyright (c) 1990-2006 Info-ZIP - Type 'zip "-L"' for software license.
> This is Zip 2.32 (June 19th 2006), by Info-ZIP.
> 
> should this version be ok?
> 
> > Also, what is the difference between t/trash/a and t/trash/d/a after
> > running the test script (that's what test 21 is comparing)?
> 
> $ diff -Naur t/trash/a t/trash/d/a
> diff -Naur t/trash/a/l1 t/trash/d/a/l1
> --- t/trash/a/l1        2007-09-17 23:10:03.000000000 +0200
> +++ t/trash/d/a/l1      2007-09-17 23:10:03.000000000 +0200
> @@ -1 +1 @@
> -simple textfile
> +a
> \ No newline at end of file

Ah, that's my friend GNU diff again... Try running the test with "-i -v", and it will pass, if I am right.

I actually made a patch for GNU diff back when this hit me, only to find out that it was fixed in CVS. Apparently, for a short period, during which 2.8.1 was released, there was a bug that prevented GNU diff from working properly when the output was redirected to a non-tty.

If I'm right, and it is that bug, it might be worthwhile to convert the calls to "diff -u" in that test script with calls to "git diff" (possibly with --no-index).

Ciao, Dscho