Re: testsuite problems

From: René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Sep 18, 2007, 17:05 UTC
Message-ID: <46F0054F.8060503@lsrfire.ath.cx>
In-Reply-To: <20070918155214.GQ19019@genesis.frugalware.org>

Miklos Vajna schrieb:

Show 24 quoted lines

> $ unzip -v
> UnZip 5.52 of 28 February 2005, by Info-ZIP.  Maintained by C. Spieler.
> Send
> bug reports using http://www.info-zip.org/zip-bug.html; see README for
> details.
> 
> Latest sources and executables are at
> ftp://ftp.info-zip.org/pub/infozip/ ;
> see ftp://ftp.info-zip.org/pub/infozip/UnZip.html for other sites.
> 
> Compiled with gcc 4.1.2 for Unix (Linux ELF) on May  9 2007.
> 
> UnZip special compilation options:
>         ASM_CRC
>         COPYRIGHT_CLEAN (PKZIP 0.9x unreducing method not supported)
>         SET_DIR_ATTRIB
>         TIMESTAMP
>         USE_EF_UT_TIME
>         USE_UNSHRINK (PKZIP/Zip 1.x unshrinking method supported)
>         USE_DEFLATE64 (PKZIP 4.x Deflate64(tm) supported)
>         VMS_TEXT_CONV
>         [decryption, version 2.9 of 05 May 2000]
> 
> if i'm not wrong then these options should be ok. :S

Well, looks OK to me at least. The Debian package (and thus Ubuntu's too) has a symlink related fix, from Christian Spieler, no less:

  http://packages.debian.org/changelogs/pool/main/u/unzip/unzip_5.52-9/changelog
  http://ftp.de.debian.org/debian/pool/main/u/unzip/unzip_5.52-9.diff.gz

Perhaps this is missing from your version?

Let's check if the ZIP file on our machines match. In order for this to succeed we need to first take out any randomness. Please apply the patch at the end of the mail, which sets GIT_AUTHOR_DATE to a fixed value instead of using the current time, run the test and then this:

  $ md5sum t/trash/d.zip	# run just after t5000-tar-tree.sh
  35f6183b7816960cadfc6cac74530640  t/trash/d.zip

The test passes just fine here, so if the checksums match then your unzip is most likely to blame. In this case you can work around your problem by commenting out the "ln -s" in t5000-tar-tree.sh.

René

--- snip! --- archive: make test repeatable

Set GIT_AUTHOR_DATE to a fixed value, just like it's already done for GIT_COMMITTER_DATE. This makes the test repeatable, and resulting archive files can by compared on mailing lists simply by comparing their checksums.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>

diff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh
index 42e28ab..f341451 100755
--- a/t/t5000-tar-tree.sh
+++ b/t/t5000-tar-tree.sh
@@ -50,7 +50,7 @@ test_expect_success \
      treeid=`git write-tree` &&
      echo $treeid >treeid &&
      git update-ref HEAD $(TZ=GMT GIT_COMMITTER_DATE="2005-05-27 22:00:00" \
-     git commit-tree $treeid </dev/null)'
+     GIT_AUTHOR_DATE="2007-09-18 19:00:00" git commit-tree $treeid </dev/null)
 
 test_expect_success \
     'git archive' \