Re: [PATCH 7/8] git-gc --auto: restructure the way "repack" command line is built.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 17, 2007, 09:41 UTC
Message-ID: <Pine.LNX.4.64.0709171040070.28586@racer.site>
In-Reply-To: <1190018713416-git-send-email-gitster@pobox.com>

Hi,

On Mon, 17 Sep 2007, Junio C Hamano wrote:

Show 9 quoted lines

> @@ -154,8 +161,6 @@ int cmd_gc(int argc, const char **argv, const char *prefix)
>  		 * Auto-gc should be least intrusive as possible.
>  		 */
>  		prune = 0;
> -		for (i = 0; i < ARRAY_SIZE(argv_repack_auto); i++)
> -			argv_repack[i] = argv_repack_auto[i];
>  		if (!need_to_gc())
>  			return 0;
>  	}

This subtly changes behaviour: --auto ran also garbage collection for reflogs and rerere.

This might be intended, but is not documented.

Ciao, Dscho