Re: [PATCH 7/8] git-gc --auto: restructure the way "repack" command line is built.

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 17, 2007, 19:53 UTC
Message-ID: <7vwsupyso8.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <Pine.LNX.4.64.0709171040070.28586@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 14 quoted lines

> On Mon, 17 Sep 2007, Junio C Hamano wrote:
>
>> @@ -154,8 +161,6 @@ int cmd_gc(int argc, const char **argv, const char *prefix)
>>  		 * Auto-gc should be least intrusive as possible.
>>  		 */
>>  		prune = 0;
>> -		for (i = 0; i < ARRAY_SIZE(argv_repack_auto); i++)
>> -			argv_repack[i] = argv_repack_auto[i];
>>  		if (!need_to_gc())
>>  			return 0;
>>  	}
>
> This subtly changes behaviour: --auto ran also garbage collection for 
> reflogs and rerere.

Does it change any behaviour? It "ran" meaning "it used to run them always"? I do not think so. We always exited here if there is no gc needed for object store.

I however think a behaviour change might be needed around here. "gc --auto" is about being lightweight and no impact in the semantics from the point fo view of the repository user. As such, I suspect we may not want to run gc on reflogs nor rerere. Running pack-refs is supposed to be "no impact in the semantics" operation so I think it is Ok, but even that would affect how the ancient fetch over http implementations would interact with this repository.

But skipping these would make automated "behind the scene" gc much less useful. I dunno.