Re: [PATCH] Functions for updating refs.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 4, 2007, 14:58 UTC
Message-ID: <Pine.LNX.4.64.0709041557590.28586@racer.site>
In-Reply-To: <46DD6B93.10005@eudaptics.com>

Hi,

On Tue, 4 Sep 2007, Johannes Sixt wrote:

Show 10 quoted lines

> Johannes Schindelin schrieb:
> > On Tue, 4 Sep 2007, Carlos Rica wrote:
> > > +int update_ref_or_die(const char *action, const char *refname,
> > > +				const unsigned char *sha1,
> > > +				const unsigned char *oldval, int flags)
> > 
> > Should this not be "void"?  And should it not use update_ref_or_error()?
> 
> It should not use *_error() directly because then it would print two error
> messages in a row.

Well, my idea was to let _error() print the message, and just die().

Ciao, Dscho