git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Functions for updating refs.

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 4, 2007, 17:52 UTC
Message-ID
<7v642qnwr7.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<46DD6020.4050401@gmail.com>
Carlos Rica <jasampler@gmail.com> writes:
Show 40 quoted lines
> diff --git a/refs.c b/refs.c
> index 09a2c87..4fd5065 100644
> --- a/refs.c
> +++ b/refs.c
> @@ -1455,3 +1455,35 @@ int for_each_reflog(each_ref_fn fn, void *cb_data)
>  {
>  	return do_for_each_reflog("", fn, cb_data);
>  }
> +
> +int update_ref_or_die(const char *action, const char *refname,
> +				const unsigned char *sha1,
> +				const unsigned char *oldval, int flags)
> +{
> +	static struct ref_lock *lock;
> +	lock = lock_any_ref_for_update(refname, oldval, flags);
> +	if (!lock)
> +		die("Cannot lock the ref '%s'.", refname);
> +	if (write_ref_sha1(lock, sha1, action) < 0)
> +		die("Cannot update the ref '%s'.", refname);
> +	return 0;
> +}
> +
> +int update_ref_or_error(const char *action, const char *refname,
> +				const unsigned char *sha1,
> +				const unsigned char *oldval, int quiet)
> +{
> +	static struct ref_lock *lock;
> +	lock = lock_any_ref_for_update(refname, oldval, 0);
> +	if (!lock) {
> +		if (!quiet)
> +			error("Cannot lock the ref '%s'.", refname);
> +		return 1;
> +	}
> +	if (write_ref_sha1(lock, sha1, action) < 0) {
> +		if (!quiet)
> +			error("Cannot update the ref '%s'.", refname);
> +		return 1;
> +	}
> +	return 0;
> +}
This makes me wonder three things:
 - Why doesn't "or_error" side allow "flags" as "or_die" one?
   Could the 'quiet' option become part of "flags" perhaps?
 - They look quite similar.  Is it a good idea to refactor them
   further, or they are so small it does not matter?
 - Why isn't lock released with unlock_ref()?
Previous: Johannes SchindelinNext: Carlos Rica
Message 8 of 10 in “Functions for updating refs.”
  1. Functions for updating refs.Carlos Rica, Sep 4, 2007
  2. Johannes SchindelinSep 4, 2007
  3. Johannes SixtSep 4, 2007
  4. Johannes SchindelinSep 4, 2007
  5. Johannes SixtSep 4, 2007
  6. Karl HasselströmSep 4, 2007
  7. Johannes SchindelinSep 4, 2007
  8. Junio C HamanoSep 4, 2007
  9. Carlos RicaSep 4, 2007
  10. Junio C HamanoSep 5, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.