Re: git-svn: Protect against "diff.color = true".
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Aug 31, 2007, 21:53 UTC
- Message-ID
- <Pine.LNX.4.64.0708312251510.28586@racer.site>
- In-Reply-To
- <7vtzqfwf5c.fsf@gitster.siamese.dyndns.org>
Hi,
On Fri, 31 Aug 2007, Junio C Hamano wrote:
Show 20 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > > On Fri, 31 Aug 2007, Junio C Hamano wrote: > > > >> I do not have an easy access to SVN repo > >> to interoperate with, so a testing by real-world users and an > >> Ack is appreciated. > > > > I just tested on a busybox clone: Works as expected. Without your patch, > > I get the uninitialised values, with your patch it is fine. > > > > ACK. > > Thanks. > > It's customary that the privilege to issue Ack is reserved to > the primary owner of the code. We are a relatively small > friendly community and it is not a big deal, but if you ever > work on the kernel, be somewhat more careful. People are picky > over there on such details.
Happily, we are a much friendlier bunch here ;-)
Besides, since I feel we're really close to 1.5.3 now, I thought that you might want to here as many positive votes as you can get.
But yes, I'll keep that in mind ;-)
Ciao, Dscho