git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-svn: Protect against "diff.color = true".

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 31, 2007, 22:14 UTC
Message-ID
<7vps13wdw1.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<Pine.LNX.4.64.0708312251510.28586@racer.site>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 23 quoted lines
> On Fri, 31 Aug 2007, Junio C Hamano wrote:
>
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> ...
>> > I just tested on a busybox clone: Works as expected.  Without your patch, 
>> > I get the uninitialised values, with your patch it is fine.
>> >
>> > ACK.
>> 
>> Thanks.
>> 
>> It's customary that the privilege to issue Ack is reserved to
>> the primary owner of the code.  We are a relatively small
>> friendly community and it is not a big deal, but if you ever
>> work on the kernel, be somewhat more careful.  People are picky
>> over there on such details.
>
> Happily, we are a much friendlier bunch here ;-)
>
> Besides, since I feel we're really close to 1.5.3 now, I thought that you 
> might want to here as many positive votes as you can get.
>
> But yes, I'll keep that in mind ;-)

Oh, I did not mean to sound like your testing does not count. I was just cautioning about using the word "Ack".

I will have a "Tested-by: " line with your name on it, and I am hoping I can get an Ack from Eric but it is such an "obviously correct" looking change, so ...

Previous: Johannes SchindelinNext: Eric Wong
Message 17 of 18 in “Perl warning in git-svn (git v1.5.3-rc7-16-ge340d7d)”
  1. Robert NewsonAug 31, 2007
  2. Junio C HamanoAug 31, 2007
  3. Eric WongAug 31, 2007
  4. Robert NewsonAug 31, 2007
  5. Junio C HamanoAug 31, 2007
  6. Robert NewsonAug 31, 2007
  7. Robert NewsonAug 31, 2007
  8. Robert NewsonAug 31, 2007
  9. Junio C HamanoAug 31, 2007
  10. Junio C HamanoAug 31, 2007
  11. Sam VilainAug 31, 2007
  12. Johannes SchindelinAug 31, 2007
  13. git-svn: Protect against "diff.color = true".Junio C Hamano, Aug 31, 2007
  14. Johannes SchindelinAug 31, 2007
  15. Junio C HamanoAug 31, 2007
  16. Johannes SchindelinAug 31, 2007
  17. Junio C HamanoAug 31, 2007
  18. Eric WongAug 31, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.