Re: git-svn: Protect against "diff.color = true".
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 31, 2007, 22:14 UTC
- Message-ID
- <7vps13wdw1.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <Pine.LNX.4.64.0708312251510.28586@racer.site>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 23 quoted lines
> On Fri, 31 Aug 2007, Junio C Hamano wrote: > >> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: >> ... >> > I just tested on a busybox clone: Works as expected. Without your patch, >> > I get the uninitialised values, with your patch it is fine. >> > >> > ACK. >> >> Thanks. >> >> It's customary that the privilege to issue Ack is reserved to >> the primary owner of the code. We are a relatively small >> friendly community and it is not a big deal, but if you ever >> work on the kernel, be somewhat more careful. People are picky >> over there on such details. > > Happily, we are a much friendlier bunch here ;-) > > Besides, since I feel we're really close to 1.5.3 now, I thought that you > might want to here as many positive votes as you can get. > > But yes, I'll keep that in mind ;-)
Oh, I did not mean to sound like your testing does not count. I was just cautioning about using the word "Ack".
I will have a "Tested-by: " line with your name on it, and I am hoping I can get an Ack from Eric but it is such an "obviously correct" looking change, so ...