git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix install-doc-quick target

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 5, 2007, 18:10 UTC
Message-ID
<Pine.LNX.4.64.0708051909300.14781@racer.site>
In-Reply-To
<7vzm15eukf.fsf@assigned-by-dhcp.cox.net>
Hi,
On Sun, 5 Aug 2007, Junio C Hamano wrote:
Show 21 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > I do not like the behaviour "be stupid and assume cwd to be the working 
> > tree root, if GIT_DIR is set and GIT_WORK_TREE is not".
> >
> > It bears _all_ kind of stupid connotations.  Just imagine what would 
> > happen with "git --git-dir=. add .".
> >
> > IMHO the new behaviour is _better_, since you can not shoot yourself in 
> > the foot so easily.  Being able to safeguard against doing a work tree 
> > operation inside the git directory is a direct and elegant consequence of 
> > defaulting to $GIT_DIR/.. in case $GIT_DIR ends in "/.git", and no work 
> > tree if $GIT_DIR does _not_ end in "/.git".
> >
> > The semantics "if GIT_DIR is set, just assume the cwd to be the work tree 
> > root unilaterally" is _broken_ as far as I am concerned.
> 
> I am not disputing that.  I was just pointing out that this is a
> change in semantics and we need to advertise it as such, and
> more importantly, advise people how to adjust to the new (and
> improved) world order.

Thanks. I will prepare a patch to ReleaseNotes, but that'll have to wait until tomorrow. I'm pretty exhausted after the last night of msysGit hacking.

Ciao, Dscho

Previous: Junio C HamanoNext: Johannes Schindelin
Message 13 of 36 in “rc4 - make quick-install-doc is broken”
  1. Mark LevedahlAug 4, 2007
  2. Johannes SchindelinAug 4, 2007
  3. Mark LevedahlAug 4, 2007
  4. Johannes SchindelinAug 4, 2007
  5. Mark LevedahlAug 4, 2007
  6. Johannes SchindelinAug 4, 2007
  7. Mark LevedahlAug 4, 2007
  8. Fix quick-install-docJohannes Schindelin, Aug 4, 2007
  9. René ScharfeAug 4, 2007
  10. Fix install-doc-quick targetJunio C Hamano, Aug 5, 2007
  11. Johannes SchindelinAug 5, 2007
  12. Junio C HamanoAug 5, 2007
  13. Johannes SchindelinAug 5, 2007
  14. Johannes SchindelinAug 5, 2007
  15. (Really) Fix install-doc-quick targetMark Levedahl, Aug 6, 2007
  16. Johannes SchindelinAug 6, 2007
  17. Junio C HamanoAug 6, 2007
  18. Mark LevedahlAug 6, 2007
  19. Johannes SchindelinAug 6, 2007
  20. Mark LevedahlAug 6, 2007
  21. Junio C HamanoAug 7, 2007
  22. Mark LevedahlAug 7, 2007
  23. Junio C HamanoAug 7, 2007
  24. René ScharfeAug 7, 2007
  25. Johannes SchindelinAug 7, 2007
  26. Mark LevedahlAug 4, 2007
  27. Johannes SchindelinAug 4, 2007
  28. Mark LevedahlAug 4, 2007
  29. René ScharfeAug 4, 2007
  30. Johannes SchindelinAug 4, 2007
  31. Mark LevedahlAug 4, 2007
  32. Johannes SchindelinAug 4, 2007
  33. René ScharfeAug 4, 2007
  34. Johannes SchindelinAug 4, 2007
  35. Johannes SchindelinAug 4, 2007
  36. René ScharfeAug 4, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.