git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Fix quick-install-doc

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 4, 2007, 21:32 UTC
Message-ID
<Pine.LNX.4.64.0708042229130.14781@racer.site>
In-Reply-To
<46B4BDCF.9060809@gmail.com>

The recent work-tree cleanups exposed that the install-doc-quick script was relying on a strange behaviour predating the work-tree series: when setting a GIT_DIR, it was assumed that the current working directory is the root of the working tree.

The recent work-tree series changed that behaviour: now that you can set the work tree explicitely, the work tree root defaults to $GIT_DIR/.. if $GIT_DIR has a /.git suffix when that is a parent directory of the current working directory.

Noticed by Mark Levedahl. Diagnosed by Junio Hamano.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
	Junio, I did it slightly differently from what I said on IRC: 
	setting the work-tree with "--work-tree" does not work as 
	expected.  Will fix.
 Documentation/install-doc-quick.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Documentation/install-doc-quick.sh b/Documentation/install-doc-quick.sh
index e6601bd..5c8b604 100755
--- a/Documentation/install-doc-quick.sh
+++ b/Documentation/install-doc-quick.sh
@@ -19,7 +19,7 @@ GIT_INDEX_FILE=`pwd`/.quick-doc.index
 export GIT_INDEX_FILE
 rm -f "$GIT_INDEX_FILE"
 git read-tree $head
-git checkout-index -a -f --prefix="$mandir"/
+(cd "$mandir"; git checkout-index -a -f)
 
 if test -n "$GZ"; then
 	cd "$mandir"
-- 
1.5.3.rc4.1.g7805
Previous: Mark LevedahlNext: René Scharfe
Message 8 of 36 in “rc4 - make quick-install-doc is broken”
  1. Mark LevedahlAug 4, 2007
  2. Johannes SchindelinAug 4, 2007
  3. Mark LevedahlAug 4, 2007
  4. Johannes SchindelinAug 4, 2007
  5. Mark LevedahlAug 4, 2007
  6. Johannes SchindelinAug 4, 2007
  7. Mark LevedahlAug 4, 2007
  8. Fix quick-install-docJohannes Schindelin, Aug 4, 2007
  9. René ScharfeAug 4, 2007
  10. Fix install-doc-quick targetJunio C Hamano, Aug 5, 2007
  11. Johannes SchindelinAug 5, 2007
  12. Junio C HamanoAug 5, 2007
  13. Johannes SchindelinAug 5, 2007
  14. Johannes SchindelinAug 5, 2007
  15. (Really) Fix install-doc-quick targetMark Levedahl, Aug 6, 2007
  16. Johannes SchindelinAug 6, 2007
  17. Junio C HamanoAug 6, 2007
  18. Mark LevedahlAug 6, 2007
  19. Johannes SchindelinAug 6, 2007
  20. Mark LevedahlAug 6, 2007
  21. Junio C HamanoAug 7, 2007
  22. Mark LevedahlAug 7, 2007
  23. Junio C HamanoAug 7, 2007
  24. René ScharfeAug 7, 2007
  25. Johannes SchindelinAug 7, 2007
  26. Mark LevedahlAug 4, 2007
  27. Johannes SchindelinAug 4, 2007
  28. Mark LevedahlAug 4, 2007
  29. René ScharfeAug 4, 2007
  30. Johannes SchindelinAug 4, 2007
  31. Mark LevedahlAug 4, 2007
  32. Johannes SchindelinAug 4, 2007
  33. René ScharfeAug 4, 2007
  34. Johannes SchindelinAug 4, 2007
  35. Johannes SchindelinAug 4, 2007
  36. René ScharfeAug 4, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.