Re: [PATCH 3/8] Clean up work-tree handling
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jul 29, 2007, 20:02 UTC
- Message-ID
- <Pine.LNX.4.64.0707292100500.14781@racer.site>
- In-Reply-To
- <7vodhvm1dg.fsf@assigned-by-dhcp.cox.net>
Hi,
On Sun, 29 Jul 2007, Junio C Hamano wrote:
Show 8 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > > I still have a problem with what should happen if both "core.bare == true" > > and "core.worktree = /some/where/over/the/rainbow". Should it be bare, or > > should it have a working tree? > > They sound contradicting with each other to me. Isn't that a > clear configuration error?
Yes. But why not play nice?
Okay, the real reason I do not want to catch this error is because it complicates my code.
But really, why not say "worktree takes precedence"?
BTW I realised that callers of setup_git_directory_gently() might forget the check for the repository format version...
Ciao, Dscho