Re: [PATCH 1/8] Add is_absolute_path() and make_absolute_path()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 27, 2007, 20:51 UTC
- Message-ID
- <7vvec5y3i0.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.64.0707271955450.14781@racer.site>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 30 quoted lines
> diff --git a/path.c b/path.c
> index c4ce962..0f7012f 100644
> --- a/path.c
> +++ b/path.c
> @@ -292,3 +292,65 @@ int adjust_shared_perm(const char *path)
> return -2;
> return 0;
> }
> +
> +/* We allow "recursive" symbolic links. Only within reason, though. */
> +#define MAXDEPTH 5
> +
> +const char *make_absolute_path(const char *path)
> +{
> + static char bufs[2][PATH_MAX + 1], *buf = bufs[0], *next_buf = bufs[1];
> + char cwd[1024] = "";
> + int buf_index = 1, len;
> +
> + int depth = MAXDEPTH;
> + char *last_elem = NULL;
> + struct stat st;
> +
> + if (strlcpy(buf, path, PATH_MAX) >= PATH_MAX)
> + die ("Too long path: %.*s", 60, path);
> +
> + while (depth--) {
> + if (stat(buf, &st) || !S_ISDIR(st.st_mode)) {
> + char *last_slash = strrchr(buf, '/');
> + *last_slash = '\0';
> + last_elem = xstrdup(last_slash + 1);What happens when incoming path is just "abc"? Does your test script checks that case?