Re: [PATCH] Don't rely on unspecified behavior

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 28, 2007, 19:30 UTC
Message-ID: <Pine.LNX.4.64.0707282028130.14781@racer.site>
In-Reply-To: <11856471952272-git-send-email-tschwinge@gnu.org>

Hi,

On Sat, 28 Jul 2007, Thomas Schwinge wrote:

Show 5 quoted lines

> Calling access(p, m) with p == NULL is not specified, so don't do that.  On
> GNU/Hurd systems doing so will result in a SIGSEGV.
> 
> Signed-off-by: Thomas Schwinge <tschwinge@gnu.org>
> ---

Isn't this the same patch as you sent before?

Show 13 quoted lines

>  builtin-add.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/builtin-add.c b/builtin-add.c
> index 7345479..de5c108 100644
> --- a/builtin-add.c
> +++ b/builtin-add.c
> @@ -60,7 +60,7 @@ static void fill_directory(struct dir_struct *dir, const char **pathspec,
>  		path = git_path("info/exclude");
>  		if (!access(path, R_OK))
>  			add_excludes_from_file(dir, path);
> -		if (!access(excludes_file, R_OK))
> +		if (excludes_file != NULL && !access(excludes_file, R_OK))

We usually omit the "!= NULL"; see the other source code in git.git.

Ciao, Dscho