Re: [PATCH] Don't rely on unspecified behavior
- From
- Thomas Glanzmann <thomas@glanzmann.de>
- Date
- Jul 28, 2007, 17:39 UTC
- Message-ID
- <20070728173948.GD23337@cip.informatik.uni-erlangen.de>
- In-Reply-To
- <11856407791617-git-send-email-tschwinge@gnu.org>
Hello,
> Calling access(p, m) with p == NULL is not specified, so don't do > that. On GNU/Hurd systems doing so will result in an SIGSEGV.
a friend of mine choked on this one when tried git for the second time (the first time "git-repack -a -d -f" screwed his repository after the initial checkout. This is fixed for a long time). Lucky me that he had his libusbdriver in LD_PRELOAD which could not handle the NULL argument. And I always thought libc would make the check before it does the system call or does GNU/hurts not use the gnu libc?
Thomas