Re: [PATCH] Prefer $EMAIL over auto-generated user@hostname.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 6, 2007, 15:32 UTC
Message-ID: <Pine.LNX.4.64.0707061631560.4093@racer.site>
In-Reply-To: <468E5E31.8040504@nrlssc.navy.mil>

Hi,

On Fri, 6 Jul 2007, Brandon Casey wrote:

Show 17 quoted lines

> Uwe Kleine-K?nig wrote:
> > Hello Brandon,
> > 
> > Brandon Casey wrote:
> >>  	struct passwd *pw = NULL;
> >> +        char *email;
> > Indention error. Otherwise it looks good (just from reading the patch).
> 
> huh. It doesn't look like that in my mail reader.
> I have
>         struct passwd...
> +        char *email;
> 
> and the patch applied cleanly when I saved the email and applied it
> using git-am
> 
>   cat git_email.patch | git-am

Yes, it applies cleanly. But it has 8 spaces before "char *email", not a tab (otherwise it would be lined up with "struct passwd").

Hth, Dscho