git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Prefer $EMAIL over auto-generated user@hostname.

From
Brandon Casey <casey@nrlssc.navy.mil>
Date
Jul 6, 2007, 15:51 UTC
Message-ID
<468E64F9.9080805@nrlssc.navy.mil>
In-Reply-To
<Pine.LNX.4.64.0707061631560.4093@racer.site>
Johannes Schindelin wrote:
Show 23 quoted lines
> Hi,
> 
> On Fri, 6 Jul 2007, Brandon Casey wrote:
> 
>> Uwe Kleine-K?nig wrote:
>>> Hello Brandon,
>>>
>>> Brandon Casey wrote:
>>>>  	struct passwd *pw = NULL;
>>>> +        char *email;
>>> Indention error. Otherwise it looks good (just from reading the patch).
>> huh. It doesn't look like that in my mail reader.
>> I have
>>         struct passwd...
>> +        char *email;
>>
>> and the patch applied cleanly when I saved the email and applied it
>> using git-am
>>
>>   cat git_email.patch | git-am
> 
> Yes, it applies cleanly. But it has 8 spaces before "char *email", not a 
> tab (otherwise it would be lined up with "struct passwd").

Ahh. I have expandtab set in .vimrc This wouldn't happen to be part of the war on white space? converting spaces to tabs where applicable?

Is the recommended tab stop 8 characters as it is for linux? or 4?
-brandon
Previous: Johannes SchindelinNext: Alex Riesen
Message 5 of 9 in “Prefer $EMAIL over auto-generated user@hostname.”
  1. Prefer $EMAIL over auto-generated user@hostname.Brandon Casey, Jul 6, 2007
  2. Uwe Kleine-KönigJul 6, 2007
  3. Brandon CaseyJul 6, 2007
  4. Johannes SchindelinJul 6, 2007
  5. Brandon CaseyJul 6, 2007
  6. Alex RiesenJul 6, 2007
  7. Vincent HanquezJul 6, 2007
  8. Alex RiesenJul 6, 2007
  9. Alex RiesenJul 6, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.