Re: [PATCH] Prefer $EMAIL over auto-generated user@hostname.
- From
Brandon Casey <casey@nrlssc.navy.mil>
- Date
- Jul 6, 2007, 15:51 UTC
- Message-ID
- <468E64F9.9080805@nrlssc.navy.mil>
- In-Reply-To
- <Pine.LNX.4.64.0707061631560.4093@racer.site>
Johannes Schindelin wrote:
Show 23 quoted lines
> Hi, > > On Fri, 6 Jul 2007, Brandon Casey wrote: > >> Uwe Kleine-K?nig wrote: >>> Hello Brandon, >>> >>> Brandon Casey wrote: >>>> struct passwd *pw = NULL; >>>> + char *email; >>> Indention error. Otherwise it looks good (just from reading the patch). >> huh. It doesn't look like that in my mail reader. >> I have >> struct passwd... >> + char *email; >> >> and the patch applied cleanly when I saved the email and applied it >> using git-am >> >> cat git_email.patch | git-am > > Yes, it applies cleanly. But it has 8 spaces before "char *email", not a > tab (otherwise it would be lined up with "struct passwd").
Ahh. I have expandtab set in .vimrc This wouldn't happen to be part of the war on white space? converting spaces to tabs where applicable?
Is the recommended tab stop 8 characters as it is for linux? or 4?
-brandon