Re: [PATCH] filter-branch documentation: some more touch-ups.
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jul 4, 2007, 10:58 UTC
- Message-ID
- <Pine.LNX.4.64.0707041155110.4071@racer.site>
- In-Reply-To
- <1183534367401-git-send-email-johannes.sixt@telecom.at>
Hi,
On Wed, 4 Jul 2007, Johannes Sixt wrote:
Show 9 quoted lines
> - The map function used to fail, but no longer does (since 3520e1e8687.) > - Fix the "edge-graft" example. > - Show the same using .git/info/grafts. > > Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at> > --- > > I think that "edge-graft" makes more sense than "etch-graft". > Native speakers, please?
I looked at dict.leo.org, and it does not know either version. Maybe it is just "graft"?
Except for that,
Acked-by: Johannes E. Schindelin <johannes.schindelin@gmx.de>
> I tried the example, and its quoting was incorrect. The reason is that > the shell removes the single quotes even if they are in the middle of > a word; so they didn't end up in the eval'd script and made sed barf.
Thanks for sanity checking. It looked so obviously correct to me that I did not bother checking, but your are correct, they were broken. Unfortunately, I even would have missed it writing a test case, because that need an extra level of quoting!
Ciao, Dscho