git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Document git-filter-branch

From
Frank Lichtenheld <frank@lichtenheld.de>
Date
Jul 4, 2007, 11:29 UTC
Message-ID
<20070704112900.GO12721@planck.djpig.de>
In-Reply-To
<Pine.LNX.4.64.0707040004200.4071@racer.site>
On Wed, Jul 04, 2007 at 12:17:05AM +0100, Johannes Schindelin wrote:
Show 12 quoted lines
> Hi,
> 
> [if you comment on just a small portion of the text, could you please 
> quote only that? Thank you]
> 
> On Wed, 4 Jul 2007, Frank Lichtenheld wrote:
> 
> > General note: All the stuff in all uppercase should probably also
> > have some asciidoc emphasis.
> 
> I do not understand. I grepped through all the docs for uppercase words 
> emphasized in any way, and could not find one.

True. On the other hand it is used at least in the case of WARNING as a means of emphasis and this should be reflected in the end result as markup. So I still suggest changing it to *WARNING* or even *Warning* if you don't want to double the emphasis.

Show 11 quoted lines
> > On Tue, Jul 03, 2007 at 05:47:44PM +0100, Johannes Schindelin wrote:
> > > +the id of the commit being rewritten.  The author/committer environment
> > > +variables are set before the first filter is run.
> > 
> > Maybe give the actual names of the environment variables here?
> 
> If you think so:
> 
> 	Also, GIT_AUTHOR_NAME, GIT_AUTHOR_EMAIL, GIT_AUTHOR_DATE, 
> 	GIT_COMMITTER_NAME, GIT_COMMITTER_EMAIL, and GIT_COMMITTER_DATE is 
> 	set according to the current commit.

"are" set. And yeah, it doesn't look pretty. I still prefer having the list somewhere in the text, though.

Show 9 quoted lines
> > > +	Only regard the history, as seen by the given subdirectory. The
> >                               ^^^
> > Does this comma belong there?
> 
> This is my bad English. What I meant was this:
> 
>         Only ever look at the history, which touches the given 
> 	subdirectory.  The result will contain that directory as its 
> 	project root.

I'm still not sure there should be a comma in this sentence, but my English grammar is a bit rusty.

Gruesse,
-- 
Frank Lichtenheld <frank@lichtenheld.de>
www: http://www.djpig.de/
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 4 of 12 in “Document git-filter-branch”
  1. Document git-filter-branchJohannes Schindelin, Jul 3, 2007
  2. Frank LichtenheldJul 3, 2007
  3. Johannes SchindelinJul 3, 2007
  4. Frank LichtenheldJul 4, 2007
  5. filter-branch: a few more touch ups to the man pageJohannes Schindelin, Jul 4, 2007
  6. Frank LichtenheldJul 4, 2007
  7. Jakub NarebskiJul 11, 2007
  8. Johannes SchindelinJul 11, 2007
  9. Document git-filter-branchJohannes Schindelin, Jul 3, 2007
  10. filter-branch documentation: some more touch-ups.Johannes Sixt, Jul 4, 2007
  11. Johannes SchindelinJul 4, 2007
  12. Junio C HamanoJul 4, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.