Re: [PATCH] git-fsck: add --lost-found option

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 2, 2007, 23:26 UTC
Message-ID: <Pine.LNX.4.64.0707030018120.4071@racer.site>
In-Reply-To: <7vabuewgdb.fsf@assigned-by-dhcp.cox.net>

Hi,

On Mon, 2 Jul 2007, Junio C Hamano wrote:

Show 11 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > With this option, dangling objects are not only reported, but also 
> > written to .git/lost-found/commit/ or .git/lost-found/other/.
> >
> > This obsoletes git-lost-found.
> 
> [...]
> 
> Please do not do that in a single patch.  This patch is at least
> talking about three timeframes.

Right. My fault.

Show 6 quoted lines

>  1. git-fsck learns --lost-found
>     The patch adds that to the code and the documentation.
>     Then it is commented on, perhaps updated, and matures.
> 
>  2. git-lost-found is marked as "deprecated"
>     This patch adds "deprecated" warning to the documentation.

How about combining these two, and give a big

	WARNING: 'git lost-found' is deprecated.
	WARNING: Use 'git fsck --lost-found' instead

whenever lost-found is called?

>  3. git-lost-found is removed.

Yes, that can wait.

What is more important before doing 1&2 for real is this: lost-found ATM calls 'git-fsck --full --no-reflogs'. The patch does not force these two options when called with '--lost-found'. I would really appreciate opinions on this issue, and will gladly re-prepare a patch accordingly.

Ciao, Dscho