Re: [PATCH] git-fsck: add --lost-found option

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 2, 2007, 23:11 UTC
Message-ID: <7vabuewgdb.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0707021751380.4071@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> With this option, dangling objects are not only reported, but also
> written to .git/lost-found/commit/ or .git/lost-found/other/.
>
> This obsoletes git-lost-found.

I haven't had chance to look at the code yet; this is only about the design.

I think adding --lost-found to fsck is a wonderful idea. I also think deprecating lost-found and removing it in the longer term is a good idea.

Please do not do that in a single patch. This patch is at least talking about three timeframes.

 1. git-fsck learns --lost-found
    The patch adds that to the code and the documentation.
    Then it is commented on, perhaps updated, and matures.

 2. git-lost-found is marked as "deprecated"
    This patch adds "deprecated" warning to the documentation.

 3. git-lost-found is removed.