git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFH] pp_header(): work around possible memory corruption

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jun 23, 2007, 23:32 UTC
Message-ID
<Pine.LNX.4.64.0706240031220.4059@racer.site>
In-Reply-To
<7vps3w4g9x.fsf@assigned-by-dhcp.pobox.com>
Hi,
On Fri, 15 Jun 2007, Junio C Hamano wrote:
> At least the older humongous pretty_print_commit() got separated into 
> manageable chunks, and I was happy.  I was just too lazy when 
> refactoring the code and stopped there.
Understandable.
> The right fix is to propagate the "realloc as needed" callchain into 
> add_user_info(), instead of having "this should be enough" there.  
> These two you touched are the only two callsite of that static function.

I had a go at this, but unfortunately I do not understand enough of what is going on there. For example, add_rfc2047() sometimes quotes some text. I have no idea what a conservative estimate of the growth is, so I cannot continue there.

Sorry, Dscho

Previous: Johannes Schindelin
Message 4 of 4 in “pp_header(): work around possible memory corruption”
  1. pp_header(): work around possible memory corruptionJohannes Schindelin, Jun 15, 2007
  2. Junio C HamanoJun 16, 2007
  3. Johannes SchindelinJun 19, 2007
  4. Johannes SchindelinJun 23, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.