Re: [PATCH/RFH] pp_header(): work around possible memory corruption

From

Johannes Schindelin <johannes.schindelin@gmx.de>

Date

Jun 19, 2007, 00:19 UTC

Message-ID

<Pine.LNX.4.64.0706190118230.4059@racer.site>

In-Reply-To

<7vps3w4g9x.fsf@assigned-by-dhcp.pobox.com>

Hi,

On Fri, 15 Jun 2007, Junio C Hamano wrote:

> At least the older humongous pretty_print_commit() got separated into 
> manageable chunks, and I was happy.  I was just too lazy when 
> refactoring the code and stopped there.

That's perfectly okay. This is why you parked it in 'next', I guess.

> The right fix is to propagate the "realloc as needed" callchain into 
> add_user_info(), instead of having "this should be enough" there.  
> These two you touched are the only two callsite of that static function.