git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] filter-branch: support skipping of commits more easily

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jun 8, 2007, 04:17 UTC
Message-ID
<Pine.LNX.4.64.0706080455440.4046@racer.site>
In-Reply-To
<7v7iqfnuo3.fsf@assigned-by-dhcp.cox.net>
Hi,
On Thu, 7 Jun 2007, Junio C Hamano wrote:
Show 37 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > When commit-filter echoes just "skip", just skip that commit by mapping 
> > its object name to the same (possibly rewritten) object name(s) its 
> > parent(s) are mapped to.
> >
> > IOW, given A-B-C, if commit-filter says "skip" upon B, the rewritten 
> > branch will look like this: A'-C'.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> >
> > 	Of course, if you think of "patchsets", this behaviour might
> > 	be unexpected, since the children will still contain everything
> > 	which was changed in the skipped revisions, and not changed in
> > 	_them_.
> 
> I think that is fine; in effect, by saying "skip" B, you are
> squashing B-C into C'.
> 
> Does this mean that, given
> 
>           C---D---E
>          /   /
> 	A---B
> 
> and if commit-filter says "skip" on D, the written history would
> look like this?
> 
>           C'------E'
>          /       /
> 	A'--B'--'
> 
> The new commit E' would become an evil merge that has difference
> between D and E in the original history?
> 
> I am not objecting; just trying to get a mental picture.

Yeah, but you called it "squash" instead of "skip". So, maybe it should accept "squash" to do that operation instead?

Ciao, Dscho

Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 4 in “filter-branch: support skipping of commits more easily”
  1. filter-branch: support skipping of commits more easilyJohannes Schindelin, Jun 7, 2007
  2. Junio C HamanoJun 8, 2007
  3. Johannes SchindelinJun 8, 2007
  4. Junio C HamanoJun 8, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.